Remove TOP_TABLES_BY_WASTED_SPACE_COUNT from UiConstants #1757
Conversation
|
This pull request is not mergeable. Please rebase and repush. |
europ
force-pushed
the
remove-ui-constants-8
branch
from
3ebdbe0 to
a51f486
Compare
|
This pull request is not mergeable. Please rebase and repush. |
europ
force-pushed
the
remove-ui-constants-8
branch
from
a51f486 to
0bc7a40
Compare
| @@ -125,7 +125,7 @@ def textual_vmdb_tables_most_wasted_space | |||
| :title => _("Tables with Most Wasted Space"), | |||
There was a problem hiding this comment.
@europ move the constant definition on the beginning of this method, instead of leaving a random number in the code
There was a problem hiding this comment.
@romanblanco , I see your point. But this constant is really in just one place and we removed more constants like that. Maybe we could replace more of the "5" that serve similar purpose with a single constant in a follow up PR?
|
This pull request is not mergeable. Please rebase and repush. |
europ
force-pushed
the
remove-ui-constants-8
branch
from
0bc7a40 to
2506bf7
Compare
|
Checked commits europ/manageiq-ui-classic@46f3df6~...2506bf7 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Issue: #1661
We have removed
TOP_TABLES_BY_WASTED_SPACE_COUNTconstant fromUiConstants. One occurrence of constantTOP_TABLES_BY_WASTED_SPACE_COUNTwas replaced with its value inmanageiq-ui-classic/app/helpers/ops_helper/textual_summary.rb.